feat(tempo): add split payments for charge by brendanjryan · Pull Request #231 · wevm/mppx

brendanjryan · 2026-03-24T22:40:52Z

Summary

add splits support to Tempo charge request validation and wire serialization
build ordered primary-plus-split transfer sequences on the client and verify them for both transaction and hash credentials on the server
extend fee-payer validation for split transfers and add split-focused tests plus a changeset

pkg-pr-new · 2026-03-25T00:06:10Z

npm i https://pkg.pr.new/mppx@231

commit: 6fe20f0

pkg-pr-new · 2026-03-25T00:06:10Z

Open in StackBlitz

npm i https://pkg.pr.new/mppx@231

commit: b944184

legion2002 · 2026-03-27T18:58:58Z

👁️ Cyclops Security Review

49263cb

🧭 Auditing · mode=normal · workers 0/3 done (3 left) · verify pending 0

Worker	Engine	Progress	Status
`pr-231-w1`	gemini-3.1-pro-preview	· · ·	Running
`pr-231-w2`	amp/deep	· · ·	Running
`pr-231-w3`	gpt-5.4	· · ·	Running

⚙️ Controls

🚀 Keep only 1 remaining iteration per worker after the current work finishes.
👀 Keep only 2 remaining iterations per worker after the current work finishes.
❤️ Let only worker 1 continue; other workers skip queued iterations.
😄 Let only worker 2 continue; other workers skip queued iterations.
🎉 End faster by skipping queued iterations and moving toward consolidation.
😕 Stop active workers/verifiers now and start consolidation immediately.

tempoxyz-bot · 2026-03-27T19:28:30Z

👁️ Cyclops Security Review

49263cb

🧭 Auditing · mode=normal · workers 0/3 done (3 left) · verify pending 0

Worker	Engine	Progress	Status
`pr-231-w1`	gemini-3.1-pro-preview	🔍 thread-1 · ·	Running
`pr-231-w2`	amp/deep	🔍 thread-1 · ·	Running
`pr-231-w3`	gpt-5.4	🔍 thread-1 · ·	Running

⚙️ Controls

🚀 Keep only 1 remaining iteration per worker after the current work finishes.
👀 Keep only 2 remaining iterations per worker after the current work finishes.
❤️ Let only worker 1 continue; other workers skip queued iterations.
😄 Let only worker 2 continue; other workers skip queued iterations.
🎉 End faster by skipping queued iterations and moving toward consolidation.
😕 Stop active workers/verifiers now and start consolidation immediately.

📜 3 events

🔍 pr-231-w1 iter 1/3 [audit-ripple.md]
🔍 pr-231-w2 iter 1/3 [audit-focused.md]
🔍 pr-231-w3 iter 1/3 [audit-deep-focus.md]

tmm · 2026-03-27T21:31:09Z

.changeset/quiet-cooks-smile.md

+---
+'mppx': minor
+---


unless this is a breaking change, would use patch since we are pre-v1

Suggested change

---

'mppx': minor

---

---

'mppx': patch

---

tmm · 2026-03-27T21:31:28Z

.changeset/quiet-cooks-smile.md

+'mppx': minor
+---
+
+Add split-payment support to Tempo charge requests, including client transaction construction and stricter server verification for split transfers.


Suggested change

Add split-payment support to Tempo charge requests, including client transaction construction and stricter server verification for split transfers.

Added split-payment support to Tempo charge requests, including client transaction construction and stricter server verification for split transfers.

tmm · 2026-03-27T21:32:15Z

src/tempo/client/Charge.ts

+     * Allowlist of expected split recipient addresses. When set, the client
+     * rejects any challenge whose split recipients are not in this list.
+     */
+    expectedRecipients?: readonly string[] | undefined


Address instead of string?

tmm · 2026-03-27T21:32:28Z

src/tempo/internal/charge.ts

+export type Split = {
+  amount: string
+  memo?: string | undefined
+  recipient: string


tmm · 2026-03-27T21:32:31Z

src/tempo/internal/charge.ts

+export type Transfer = {
+  amount: string
+  memo?: string | undefined
+  recipient: string


tmm · 2026-03-27T21:32:35Z

src/tempo/internal/charge.ts

+export function getTransfers(request: {
+  amount: string
+  methodDetails?: { memo?: string | undefined; splits?: readonly Split[] | undefined }
+  recipient: string


- order-insensitive matching for both calldata and logs - hash path uses log-only verification (spec conformance) - bind validBefore to min(now+25s, challenge.expires) - add expectedRecipients allowlist for client-side split validation - allow transferWithMemo on memo-less split entries - enforce exact call count only for fee-payer transactions - sort by specificity (memo-required first) to prevent greedy matching - try/catch in decodeTransferCall for malformed calldata resilience - remove dead assertTransferLog and unused imports

…ch on localnet)

Prevents cross-route credential replay where a credential issued for a no-splits (or no-memo) route is accepted on a route that requires splits or a specific memo. The methodDetails fields memo and splits now participate in the scope comparison alongside amount, currency, and recipient.

…ipients

brendanjryan force-pushed the brendanjryan/pr203-split-payments branch 8 times, most recently from 7e70a6c to d56bda9 Compare March 24, 2026 23:58

brendanjryan mentioned this pull request Mar 25, 2026

fix: bind tempo attribution memo suffix to challenge id #232

Closed

brendanjryan force-pushed the brendanjryan/pr203-split-payments branch from d56bda9 to b944184 Compare March 25, 2026 00:05

brendanjryan force-pushed the brendanjryan/pr203-split-payments branch 3 times, most recently from 499b36f to cce70a1 Compare March 26, 2026 21:27

brendanjryan requested review from jxom and tmm March 27, 2026 20:02

This was referenced Mar 27, 2026

docs: add split payments documentation tempoxyz/mpp#480

Merged

fix: add memo and splits to challenge scope binding #234

Closed

tmm reviewed Mar 27, 2026

View reviewed changes

brendanjryan added 8 commits March 27, 2026 15:30

feat(tempo): add split payments for charge

d56fbef

fix: resolve tsgo type errors for Call and Address types

f0c48ce

fix: coerce isFeePayerTx to boolean for tsgo

02efc67

fix: use pull mode for split payment tests (sendCallsSync doesn't bat…

8ac4314

…ch on localnet)

style: apply formatter

d5cc3ea

fix(tempo): align charge flow with split payment spec

a4ace86

chore(tempo): keep split payment PR narrowly scoped

ed1f7e2

brendanjryan force-pushed the brendanjryan/pr203-split-payments branch from a4f66d6 to a1ec1a9 Compare March 27, 2026 22:30

fix: address review - patch changeset, use Address type for split rec…

6fe20f0

…ipients

brendanjryan force-pushed the brendanjryan/pr203-split-payments branch from a1ec1a9 to 6fe20f0 Compare March 27, 2026 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(tempo): add split payments for charge#231

feat(tempo): add split payments for charge#231
brendanjryan wants to merge 10 commits intomainfrom
brendanjryan/pr203-split-payments

brendanjryan commented Mar 24, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 25, 2026

Uh oh!

legion2002 commented Mar 27, 2026

Uh oh!

tempoxyz-bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

tmm Mar 27, 2026

Uh oh!

brendanjryan Mar 27, 2026

Uh oh!

tmm Mar 27, 2026

Uh oh!

tmm Mar 27, 2026

Uh oh!

tmm Mar 27, 2026

Uh oh!

tmm Mar 27, 2026

Uh oh!

tmm Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	Add split-payment support to Tempo charge requests, including client transaction construction and stricter server verification for split transfers.
	Added split-payment support to Tempo charge requests, including client transaction construction and stricter server verification for split transfers.

Uh oh!

Conversation

brendanjryan commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

pkg-pr-new bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 25, 2026

Uh oh!

legion2002 commented Mar 27, 2026

👁️ Cyclops Security Review

Uh oh!

tempoxyz-bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁️ Cyclops Security Review

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

brendanjryan Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

tmm Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

brendanjryan commented Mar 24, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 25, 2026 •

edited

Loading

tempoxyz-bot commented Mar 27, 2026 •

edited

Loading